linux-kernel - Re: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <133be287646ff03e251b0a590b240fef650a0c19.camel@suse.de>
Date:   Tue, 22 Sep 2020 12:34:16 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Support Opensource <support.opensource@...semi.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Milo Kim <milo.kim@...com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Tony Lindgren <tony@...mide.com>,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE

On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

>  drivers/mfd/bcm2835-pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
> index 42fe67f1538e..a76014512bde 100644
> --- a/drivers/mfd/bcm2835-pm.c
> +++ b/drivers/mfd/bcm2835-pm.c
> @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  	if (IS_ERR(pm->base))
>  		return PTR_ERR(pm->base);
>  
> -	ret = devm_mfd_add_devices(dev, -1,
> +	ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  				   bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs),
>  				   NULL, 0, NULL);
>  	if (ret)
> @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  		if (IS_ERR(pm->asb))
>  			return PTR_ERR(pm->asb);
>  
> -		ret = devm_mfd_add_devices(dev, -1,
> +		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  					   bcm2835_power_devs,
>  					   ARRAY_SIZE(bcm2835_power_devs),
>  					   NULL, 0, NULL);


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)