linux-kernel - Re: [PATCH] s390/zcrypt: Fix a size determination in zcrypt_unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0091c0b5-ea48-dce2-1180-49a6b87113e4@de.ibm.com>
Date:   Tue, 22 Sep 2020 12:47:05 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     freude@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        schwidefsky@...ibm.com, linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390/zcrypt: Fix a size determination in
 zcrypt_unlocked_ioctl()

On 22.09.20 12:30, Zhenzhong Duan wrote:
> With new ioctl(ZCRYPT_PERDEV_REQCNT) introduced, kernel use dynamic
> allocation for the 256 element array of unsigned integers for the number
> of successfully completed requests per device. It's not a static array of
> 64 elements any more.
> 
> Fixes: af4a72276d49 ("s390/zcrypt: Support up to 256 crypto adapters.")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...il.com>

Thanks for the patch, but we have a similar patch already queued internally.
(Found with coccicheck). 
> ---
>  drivers/s390/crypto/zcrypt_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c
> index 4dbbfd88262c..5c3f3f89e2f3 100644
> --- a/drivers/s390/crypto/zcrypt_api.c
> +++ b/drivers/s390/crypto/zcrypt_api.c
> @@ -1449,7 +1449,7 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd,
>  		if (!reqcnt)
>  			return -ENOMEM;
>  		zcrypt_perdev_reqcnt(reqcnt, AP_DEVICES);
> -		if (copy_to_user((int __user *) arg, reqcnt, sizeof(reqcnt)))
> +		if (copy_to_user((int __user *) arg, reqcnt, sizeof(u32) * AP_DEVICES))
>  			rc = -EFAULT;
>  		kfree(reqcnt);
>  		return rc;
>