linux-kernel - Re: [net-next] net: dsa: felix: convert TAS link speed based on phylink speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 11:36:45 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        "joergen.andreasen@...rochip.com" <joergen.andreasen@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Po Liu <po.liu@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Leo Li <leoyang.li@....com>
Subject: Re: [net-next] net: dsa: felix: convert TAS link speed based on
 phylink speed

Hi Xiaoliang,

On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote:
> state->speed holds a value of 10, 100, 1000 or 2500, but
> QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the
> speed to a proper value.
> 
> Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler via
> taprio offload")
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

But next time keep in mind the following:

- The Fixes: tag should never wrap on multiple lines, even if it exceeds
  80 characters.
- Patches that fix a problem in net-next only should go to David's
  net-next tree. Patches that fix a problem on Linus Torvalds' tree
  should go to David's "net" tree. This one should go to "net", not to
  "net-next".
- All tags (Fixes, Signed-off-by, etc) should be grouped together with
  no empty lines between them.

Actually due to the first issue I mentioned, could you please resend
this?

Thanks,
-Vladimir