linux-kernel - Re:Re: [PATCH] drm/amd/display: optimize code runtime a bit

Open Source and information security mailing list archives

Message-ID: <AEcAcACLDcKt*nUYZ6IRcKql.3.1600736262001.Hmail.bernard@vivo.com>
Date:   Tue, 22 Sep 2020 08:57:42 +0800 (GMT+08:00)
From:   Bernard <bernard@...o.com>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Jun Lei <Jun.Lei@....com>, Aric Cyr <aric.cyr@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        abdoulaye berthe <abdoulaye.berthe@....com>,
        Michael Strauss <michael.strauss@....com>,
        Brandon Syu <Brandon.Syu@....com>,
        Martin Leung <martin.leung@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>, opensource.kernel@...o.com
Subject: Re:Re: [PATCH] drm/amd/display: optimize code runtime a bit

From: Alex Deucher <alexdeucher@...il.com>
Date: 2020-09-22 03:33:20
To:  Bernard Zhao <bernard@...o.com>
Cc:  Harry Wentland <harry.wentland@....com>,Leo Li <sunpeng.li@....com>,Alex Deucher <alexander.deucher@....com>,"Christian König" <christian.koenig@....com>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,Rodrigo Siqueira <Rodrigo.Siqueira@....com>,Jun Lei <Jun.Lei@....com>,Aric Cyr <aric.cyr@....com>,Wenjing Liu <wenjing.liu@....com>,abdoulaye berthe <abdoulaye.berthe@....com>,Michael Strauss <michael.strauss@....com>,Brandon Syu <Brandon.Syu@....com>,Martin Leung <martin.leung@....com>,amd-gfx list <amd-gfx@...ts.freedesktop.org>,Maling list - DRI developers <dri-devel@...ts.freedesktop.org>,LKML <linux-kernel@...r.kernel.org>,opensource.kernel@...o.com
Subject: Re: [PATCH] drm/amd/display: optimize code runtime a bit>On Mon, Sep 21, 2020 at 9:14 AM Bernard Zhao <bernard@...o.com> wrote:
>>
>> Static function dal_ddc_i2c_payloads_destroy is only called
>> in dal_ddc_service_query_ddc_data, the parameter is &payloads
>> , there is no point NULL risk, so no need to check.
>> This change is to make the code run a bit fast.
>>
>
>How about just getting rid of dal_ddc_i2c_payloads_destroy() and just
>call dal_vector_destruct() directly.

Good idea, I will resubmit a patch, thanks!

BR//Bernard

>Alex
>
>
>> Signed-off-by: Bernard Zhao <bernard@...o.com>
>> ---
>>  drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
>> index b984eecca58b..6dcc666738fc 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
>> @@ -150,9 +150,6 @@ static uint32_t dal_ddc_i2c_payloads_get_count(struct i2c_payloads *p)
>>
>>  static void dal_ddc_i2c_payloads_destroy(struct i2c_payloads *p)
>>  {
>> -       if (!p)
>> -               return;
>> -
>>         dal_vector_destruct(&p->payloads);
>>  }
>>
>> --
>> 2.28.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives