linux-kernel - Re: [PATCH 08/10] rpmsg: core: Add RPMSG byte conversion operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49d5921c-c619-f9de-3ff1-f2617d3c9594@infradead.org>
Date:   Mon, 21 Sep 2020 18:07:10 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>, ohad@...ery.com,
        bjorn.andersson@...aro.org, guennadi.liakhovetski@...ux.intel.com
Cc:     loic.pallardy@...com, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] rpmsg: core: Add RPMSG byte conversion operations

On 9/21/20 5:09 PM, Mathieu Poirier wrote:
> +/**

Hi,
This block is not in kernel-doc format, so the comment block should not
begin with /**.

> + * rpmsg{16|32}_to_cpu()
> + * cpu_to_rpmsg[16|32}() - rpmsg device specific byte conversion functions to
> + *			   perform byte conversion between rpmsg device and the
> + *			   transport layer it is operating on.
> + */
> +
> +u16 rpmsg16_to_cpu(struct rpmsg_device *rpdev, u16 val)
> +{


thanks.
-- 
~Randy