linux-kernel - Re: [PATCH -next] clk: qcom: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <710ed642-cafc-7a68-dfe7-f16b6a1f81e6@gmail.com>
Date:   Tue, 22 Sep 2020 14:36:38 +0200
From:   Konrad Dybcio <konradybcio@...il.com>
To:     Li Heng <liheng40@...wei.com>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        mturquette@...libre.com, sboyd@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] clk: qcom: Remove set but not used variable

Hi,

This is not the correct solution. I sent a proper fix here [1].

Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would have had to be reverted eventually anyway..

[1] https://patchwork.kernel.org/patch/11792407/

Konrad