linux-kernel - Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 14:41:59 +0200
From:   Christian König <christian.koenig@....com>
To:     Zou Wei <zou_wei@...wei.com>, sumit.semwal@...aro.org, afd@...com,
        benjamin.gaignard@...aro.org, lmark@...eaurora.org,
        labbott@...hat.com, Brian.Starkey@....com, john.stultz@...aro.org
Cc:     linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

Am 22.09.20 um 09:53 schrieb Zou Wei:
> This patch fixes below warnings reported by coccicheck
>
> ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return "0" on line 215
>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Acked-by: Christian König <christian.koenig@....com>

Going to pick this up for drm-misc-next.

> ---
>   drivers/dma-buf/heaps/heap-helpers.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
> index d0696cf..7969510 100644
> --- a/drivers/dma-buf/heaps/heap-helpers.c
> +++ b/drivers/dma-buf/heaps/heap-helpers.c
> @@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
>   {
>   	struct heap_helper_buffer *buffer = dmabuf->priv;
>   	struct dma_heaps_attachment *a;
> -	int ret = 0;
>   
>   	mutex_lock(&buffer->lock);
>   
> @@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
>   	}
>   	mutex_unlock(&buffer->lock);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,