linux-kernel - Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22b12b8a-4c16-5377-043d-00750597f822@canonical.com>
Date:   Tue, 22 Sep 2020 13:50:12 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Jim Quinlan <james.quinlan@...adcom.com>,
        Markus Elfring <Markus.Elfring@....de>
Cc:     "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" 
        <linux-pci@...r.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Alex Dewar <alex.dewar90@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jim Quinlan <jquinlan@...adcom.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return
 error check

On 22/09/2020 13:43, Jim Quinlan wrote:
> On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring <Markus.Elfring@....de> wrote:
>>
>>> The error return ret is not being check with an if statement and
>>
>> Wording alternative:
>> The return value from a call of the function “brcm_phy_start” was not checked and
>>
>>
>>> V2: disable clock as noted by Florian Fainelli and suggested by
>>>     Jim Quinlan.
>>
>> Alex Dewar contributed another update suggestion.
>>
>> [PATCH v2] PCI: brcmstb: Add missing if statement and error path
>> https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@gmail.com/
>> https://lore.kernel.org/patchwork/patch/1309860/
>>
>> The exception handling needs further development considerations
>> for this function implementation.
> Hello,
> 
> I agree with Alex's patch.  I should have suggested this at the
> beginning but as our upstream STB suspend/resume is not yet functional
> and the one-line change would have worked until we fixed
> suspend/resume..  But this is the proper modification.

Yup, go with Alex's patch. That one is correct.


> 
> Thanks,
> Jim
>> Regards,
>> Markus