linux-kernel - Re: [PATCH -next] pinctrl: spear: simplify the return expression of tvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200922133037.cehknuxert4hdsaw@vireshk-i7>
Date:   Tue, 22 Sep 2020 19:00:37 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Viresh Kumar <vireshk@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] pinctrl: spear: simplify the return expression of
 tvc_connect()

On 21-09-20, 21:10, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/pinctrl/spear/pinctrl-spear320.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/pinctrl/spear/pinctrl-spear320.c b/drivers/pinctrl/spear/pinctrl-spear320.c
> index 99c10fc3d..e629e3035 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear320.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear320.c
> @@ -3418,8 +3418,6 @@ static const struct of_device_id spear320_pinctrl_of_match[] = {
>  
>  static int spear320_pinctrl_probe(struct platform_device *pdev)
>  {
> -	int ret;
> -
>  	spear3xx_machdata.groups = spear320_pingroups;
>  	spear3xx_machdata.ngroups = ARRAY_SIZE(spear320_pingroups);
>  	spear3xx_machdata.functions = spear320_functions;
> @@ -3433,11 +3431,7 @@ static int spear320_pinctrl_probe(struct platform_device *pdev)
>  	pmx_init_gpio_pingroup_addr(spear3xx_machdata.gpio_pingroups,
>  			spear3xx_machdata.ngpio_pingroups, PMX_CONFIG_REG);
>  
> -	ret = spear_pinctrl_probe(pdev, &spear3xx_machdata);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return spear_pinctrl_probe(pdev, &spear3xx_machdata);
>  }
>  
>  static struct platform_driver spear320_pinctrl_driver = {

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh