linux-kernel - Re: [PATCH 4.19 43/49] Input: trackpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200923204206.GN1681290@dtor-ws>
Date:   Wed, 23 Sep 2020 13:42:06 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Vincent Huang <vincent.huang@...synaptics.com>
Subject: Re: [PATCH 4.19 43/49] Input: trackpoint - add new trackpoint
 variant IDs

On Tue, Sep 22, 2020 at 10:24:03PM +0200, Pavel Machek wrote:
> On Tue 2020-09-22 18:16:42, Greg Kroah-Hartman wrote:
> > On Tue, Sep 22, 2020 at 05:39:57PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > From: Vincent Huang <vincent.huang@...synaptics.com>
> > > > 
> > > > commit 6c77545af100a72bf5e28142b510ba042a17648d upstream.
> > > > 
> > > > Add trackpoint variant IDs to allow supported control on Synaptics
> > > > trackpoints.
> > > 
> > > This just adds unused definitions. I don't think it is needed in
> > > stable.
> > 
> > It add support for a new device.
> 
> No, it does not. Maybe in mainline there's followup patch that adds
> such support, but that's not in 4.19.

es, indeed, there is a chunk missing, so this patch is incomplete. It
will not cause any issues if applied, so I'll leave it to Greg to decide
what to do with this.

Vincent, there needs to be a change in trackpoint_start_protocol() to
mark these new IDs as valid. Was it s3ent in a separate patch and I
missed it?

Thanks.

-- 
Dmitry