linux-kernel - Re: [PATCH 1/7] dmaengine: at_xdmac: separate register defines into header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a63e9eb-4714-9a63-91cf-bad30e3db75b@microchip.com>
Date:   Wed, 23 Sep 2020 05:07:54 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <Eugen.Hristev@...rochip.com>, <vkoul@...nel.org>,
        <robh+dt@...nel.org>, <Ludovic.Desroches@...rochip.com>
CC:     <dmaengine@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH 1/7] dmaengine: at_xdmac: separate register defines into
 header file

Hi, Eugen,

On 9/14/20 5:09 PM, Eugen Hristev wrote:
> Separate register defines into header file.
> This is required to support a slightly different version of the register
> map in new hardware versions of the XDMAC.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> ---
>  drivers/dma/at_xdmac.c      | 143 +--------------------------------
>  drivers/dma/at_xdmac_regs.h | 154 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 155 insertions(+), 142 deletions(-)
>  create mode 100644 drivers/dma/at_xdmac_regs.h

Even with the sama7g5 support there is a single .c file that includes
the .h. I wouldn't split the registers definitions in a dedicated file.

Cheers,
ta