linux-kernel - Re: [PATCH v2] iommu/arm: Add module parameter to set msi iova address

Open Source and information security mailing list archives

Message-ID: <85f7d1ae-71a9-4e95-8a30-03cc699d4794@redhat.com>
Date:   Wed, 23 Sep 2020 08:32:43 +0200
From:   Auger Eric <eric.auger@...hat.com>
To:     Will Deacon <will@...nel.org>,
        Vennila Megavannan <vemegava@...ux.microsoft.com>
Cc:     jean-philippe@...aro.org, joro@...tes.org,
        linux-kernel@...r.kernel.org, shameerali.kolothum.thodi@...wei.com,
        iommu@...ts.linux-foundation.org, tyhicks@...ux.microsoft.com,
        srinath.mannam@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        robin.murphy@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] iommu/arm: Add module parameter to set msi iova
 address

Hi Will,

On 9/21/20 10:45 PM, Will Deacon wrote:
> On Mon, Sep 14, 2020 at 11:13:07AM -0700, Vennila Megavannan wrote:
>> From: Srinath Mannam <srinath.mannam@...adcom.com>
>>
>> Add provision to change default value of MSI IOVA base to platform's
>> suitable IOVA using module parameter. The present hardcoded MSI IOVA base
>> may not be the accessible IOVA ranges of platform.
>>
>> If any platform has the limitaion to access default MSI IOVA, then it can
>> be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.
>>
>> Signed-off-by: Srinath Mannam <srinath.mannam@...adcom.com>
>> Co-developed-by: Vennila Megavannan <vemegava@...ux.microsoft.com>
>> Signed-off-by: Vennila Megavannan <vemegava@...ux.microsoft.com>
>> ---
>>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
>>  drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
>>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> This feels pretty fragile. Wouldn't it be better to realise that there's
> a region conflict with iommu_dma_get_resv_regions() and move the MSI window
> accordingly at runtime?

Since cd2c9fcf5c66 ("iommu/dma: Move PCI window region reservation back
into dma specific path"), the PCI host bridge windows are not exposed by
iommu_dma_get_resv_regions() anymore. If I understood correctly, what is
attempted here is to avoid the collision between such PCI host bridge
window and the MSI IOVA range.

Thanks

Eric
> 
> Will
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives