linux-kernel - Re: [PATCH] clk: tegra: Drop !provider check in tegra210_clk_emc_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200923082350.GA1203543@ulmo>
Date:   Wed, 23 Sep 2020 10:23:50 +0200
From:   Thierry Reding <treding@...dia.com>
To:     Stephen Boyd <sboyd@...nel.org>
CC:     Michael Turquette <mturquette@...libre.com>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        Joseph Lo <josephl@...dia.com>
Subject: Re: [PATCH] clk: tegra: Drop !provider check in
 tegra210_clk_emc_set_rate()

On Tue, Sep 22, 2020 at 12:16:41PM -0700, Stephen Boyd wrote:
> The provider variable is already dereferenced earlier in this function.
> Drop the check for NULL as it is impossible.
> 
> Found with smatch
> 
> drivers/clk/tegra/clk-tegra210-emc.c:131 tegra210_clk_emc_set_rate() warn: variable dereferenced before check 'provider' (see line 124)
> 
> Cc: Joseph Lo <josephl@...dia.com>
> Cc: Thierry Reding <treding@...dia.com>
> Fixes: 0ac65fc946d3 ("clk: tegra: Implement Tegra210 EMC clock")
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---
>  drivers/clk/tegra/clk-tegra210-emc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)