[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200923000800.GB531519@thinks.paulus.ozlabs.org>
Date: Wed, 23 Sep 2020 10:08:00 +1000
From: Paul Mackerras <paulus@...abs.org>
To: Wang Wensheng <wangwensheng4@...wei.com>
Cc: mpe@...erman.id.au, benh@...nel.crashing.org,
kvm-ppc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] powerpc/kvm/books: Fix symbol undeclared warnings
On Mon, Sep 21, 2020 at 11:22:11AM +0000, Wang Wensheng wrote:
> Build the kernel with `C=2`:
> arch/powerpc/kvm/book3s_hv_nested.c:572:25: warning: symbol
> 'kvmhv_alloc_nested' was not declared. Should it be static?
> arch/powerpc/kvm/book3s_64_mmu_radix.c:350:6: warning: symbol
> 'kvmppc_radix_set_pte_at' was not declared. Should it be static?
> arch/powerpc/kvm/book3s_hv.c:3568:5: warning: symbol
> 'kvmhv_p9_guest_entry' was not declared. Should it be static?
> arch/powerpc/kvm/book3s_hv_rm_xics.c:767:15: warning: symbol 'eoi_rc'
> was not declared. Should it be static?
> arch/powerpc/kvm/book3s_64_vio_hv.c:240:13: warning: symbol
> 'iommu_tce_kill_rm' was not declared. Should it be static?
> arch/powerpc/kvm/book3s_64_vio.c:492:6: warning: symbol
> 'kvmppc_tce_iommu_do_map' was not declared. Should it be static?
> arch/powerpc/kvm/book3s_pr.c:572:6: warning: symbol 'kvmppc_set_pvr_pr'
> was not declared. Should it be static?
>
> Those symbols are used only in the files that define them so make them
> static to fix the warnings.
>
> Signed-off-by: Wang Wensheng <wangwensheng4@...wei.com>
Thanks, applied.
Paul.
Powered by blists - more mailing lists