linux-kernel - Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db50f472-eb61-2f45-191a-94e8f53e7dd4@arm.com>
Date:   Wed, 23 Sep 2020 12:21:56 +0200
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     YueHaibing <yuehaibing@...wei.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, rostedt@...dmis.org,
        bsegall@...gle.com, mgorman@...e.de
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] sched: Remove unused inline function
 uclamp_bucket_base_value()

On 22/09/2020 15:24, YueHaibing wrote:
> There is no caller in tree, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  kernel/sched/core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
>  	return clamp_value / UCLAMP_BUCKET_DELTA;
>  }
>  
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> -	return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
>  static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
>  {
>  	if (clamp_id == UCLAMP_MIN)
> 

LGTM.

It got introduced in commit 60daf9c194106 ("sched/uclamp: Add bucket
local max tracking") but was never used.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com>