linux-kernel - Re: [PATCH] FIX the comment of struct jbd2_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200923103531.GE6719@quack2.suse.cz>
Date:   Wed, 23 Sep 2020 12:35:31 +0200
From:   Jan Kara <jack@...e.cz>
To:     Hui Su <sh_def@....com>
Cc:     tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FIX the comment of struct jbd2_journal_handle

On Wed 23-09-20 01:12:31, Hui Su wrote:
> the struct name was modified long ago, but the comment still
> use struct handle_s.
> 
> Signed-off-by: Hui Su <sh_def@....com>

Thanks for the patch. It looks good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/jbd2.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 08f904943ab2..a1ef05412acf 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -452,8 +452,8 @@ struct jbd2_inode {
>  struct jbd2_revoke_table_s;
>  
>  /**
> - * struct handle_s - The handle_s type is the concrete type associated with
> - *     handle_t.
> + * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
> + *     type associated with handle_t.
>   * @h_transaction: Which compound transaction is this update a part of?
>   * @h_journal: Which journal handle belongs to - used iff h_reserved set.
>   * @h_rsv_handle: Handle reserved for finishing the logical operation.
> -- 
> 2.25.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR