linux-kernel - Re: [PATCH] btrfs: Fix missing close devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Sep 2020 14:15:13 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     qiang.zhang@...driver.com, clm@...com, josef@...icpanda.com,
        dsterba@...e.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fix missing close devices



On 21.09.20 г. 10:29 ч., qiang.zhang@...driver.com wrote:
> From: Zqiang <qiang.zhang@...driver.com>
> 
> When the btrfs fill super error, we should first close devices and
> then call deactivate_locked_super func to free fs_info.
> 
> Signed-off-by: Zqiang <qiang.zhang@...driver.com>
> ---
>  fs/btrfs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 8840a4fa81eb..3bfd54e8f388 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1675,6 +1675,7 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type,
>  		error = security_sb_set_mnt_opts(s, new_sec_opts, 0, NULL);
>  	security_free_mnt_opts(&new_sec_opts);
>  	if (error) {
> +		btrfs_close_devices(fs_devices);
>  		deactivate_locked_super(s);
>  		return ERR_PTR(error);
>  	}
> 

NAK,

Devices are properly closed via:


deactivate_locked_super
  kill_sb (btrfs_kill_super)
    kill_anon_super
      generic_shutdown_super
       put_super (btrfs_put_super)
         close_ctree


It seems you haven't done deep enough analysis of the involved call chains.