linux-kernel - Re: [PATCH v2] perf script: add min, max to futex-contention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200923123155.GA2516911@kernel.org>
Date:   Wed, 23 Sep 2020 09:31:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Hagen Paul Pfeifer <hagen@...u.net>
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v2] perf script: add min, max to futex-contention

Em Tue, Sep 22, 2020 at 10:09:22PM +0200, Hagen Paul Pfeifer escreveu:
> Average is quite informative, but the outliners - especially max - are
> also of interest.
> 
> Before:
> 
> mutex-locker[793299] lock 5637ec61e080 contended 3400 times, 446 avg ns
> mutex-locker[793301] lock 5637ec61e080 contended 3563 times, 385 avg ns
> mutex-locker[793300] lock 5637ec61e080 contended 3110 times, 1855 avg ns
> 
> After:
> 
> mutex-locker[795251] lock 55b14e6dd080 contended 3853 times, 1279 avg ns [max: 12270 ns, min 340 ns]
> mutex-locker[795253] lock 55b14e6dd080 contended 2911 times, 518 avg ns [max: 51660261 ns, min 347 ns]
> mutex-locker[795252] lock 55b14e6dd080 contended 3843 times, 385 avg ns [max: 24323998 ns, min 338 ns]
> 
> Signed-off-by: Hagen Paul Pfeifer <hagen@...u.net>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---

Didn't apply here, I did it by hand, please check, probably some
indentation artifact.

Thanks for the patch!

- Arnaldo

diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf/scripts/python/futex-contention.py
index 0c4841acf75dadcb..ba044d20e8fff39b 100644
--- a/tools/perf/scripts/python/futex-contention.py
+++ b/tools/perf/scripts/python/futex-contention.py
@@ -47,6 +47,6 @@ def trace_begin():
 def trace_end():
 	for (tid, lock) in lock_waits:
 		min, max, avg, count = lock_waits[tid, lock]
-		print("%s[%d] lock %x contended %d times, %d avg ns" %
-			(process_names[tid], tid, lock, count, avg))
+		print("%s[%d] lock %x contended %d times, %d avg ns [max: %d ns, min %d ns]" %
+			(process_names[tid], tid, lock, count, avg, max, min))
 

 
> v2: nanosecond, not microseconds
> 
>  tools/perf/scripts/python/futex-contention.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf/scripts/python/futex-contention.py
> index c440f02627dd..7e884d46f920 100644
> --- a/tools/perf/scripts/python/futex-contention.py
> +++ b/tools/perf/scripts/python/futex-contention.py
> @@ -53,5 +53,5 @@ def trace_begin():
>  def trace_end():
>      for (tid, lock) in lock_waits:
>          min, max, avg, count = lock_waits[tid, lock]
> -        print("%s[%d] lock %x contended %d times, %d avg ns" %
> -              (process_names[tid], tid, lock, count, avg))
> +        print("%s[%d] lock %x contended %d times, %d avg ns [max: %d ns, min %d ns]" %
> +              (process_names[tid], tid, lock, count, avg, max, min))
> -- 
> 2.28.0
> 

-- 

- Arnaldo