linux-kernel - Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200923151040.2237af86@kernel.org>
Date:   Wed, 23 Sep 2020 15:10:40 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Dan Murphy <dmurphy@...com>
Cc:     <pavel@....cz>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters

On Tue, 22 Sep 2020 14:06:38 -0500
Dan Murphy <dmurphy@...com> wrote:

> Fix warnings for undefined parameters when building with W=1.
> 
> Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
>  drivers/leds/leds-lm36274.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index 10a63b7f2ecc..bf6487e9a1f4 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -26,8 +26,8 @@
>   * @lmu_data: Register and setting values for common code
>   * @regmap: Devices register map
>   * @dev: Pointer to the devices device struct
> - * @led_sources - The LED strings supported in this array
> - * @num_leds - Number of LED strings are supported in this array
> + * @led_sources: The LED strings supported in this array
> + * @num_leds: Number of LED strings are supported in this array
>   */
>  struct lm36274 {
>  	struct platform_device *pdev;
> @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
>  	.probe  = lm36274_probe,
>  	.driver = {
>  		.name = "lm36274-leds",
> +		.of_match_table = of_lm36274_leds_match,
>  	},
>  };
>  module_platform_driver(lm36274_driver)

Reviewed-by: Marek Behún <kabel@...nel.org>