linux-kernel - Re: [PATCH v2] nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19c5fa23-41c9-f5c7-beaf-aeb9655bfefd@linaro.org>
Date:   Wed, 23 Sep 2020 16:51:06 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: core: fix possibly memleak when use
 nvmem_cell_info_to_nvmem_cell()



On 23/09/2020 15:51, Vadym Kochan wrote:
>> -       return nvmem_cell_write(&cell, buf, cell.bytes);
>> +       rc = nvmem_cell_write(&cell, buf, cell.bytes);
>> +       if (rc)
>> +               kfree_const(cell->name);
>> +
>> +       return rc;
>>   }
>>   EXPORT_SYMBOL_GPL(nvmem_device_cell_write);
>>   ------------------------>cut<---------------------------
>>
>> --srini
>>
> But is it really needed to kstrdup(cell->name) for nvmem_device_cell_{read,write} ?
This boils down to if we want to use same api to parse nvmem_cell_info 
or not!

If we want to keep this simple, we can either explicitly add free for 
successful caller to nvmem_cell_info_to_nvmem_cell()!

Or

use something like what you did, but new api needs more clarity!
May be renaming __nvmem_cell_info_to_nvmem_cell to 
nvmem_cell_info_to_nvmem_cell_no_alloc would clarify that a bit!

Also can you make sure that linewrapping on function names be inline 
with existing code.

Please send v3 with that changes!


--srini
> It is used only for log error in case the unaligned access did not
> pass the check