linux-kernel - Re: [PATCH 2/3] PCI: dwc: Add common iATU register support

Open Source and information security mailing list archives

Message-ID: <20200923155700.GA820801@bogus>
Date:   Wed, 23 Sep 2020 09:57:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Murali Karicheri <m-karicheri2@...com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] PCI: dwc: Add common iATU register support

On Fri, Sep 11, 2020 at 05:50:02PM +0900, Kunihiko Hayashi wrote:
> This gets iATU register area from reg property that has reg-names "atu".
> In Synopsys DWC version 4.80 or later, since iATU register area is
> separated from core register area, this area is necessary to get from
> DT independently.
> 
> Cc: Murali Karicheri <m-karicheri2@...com>
> Cc: Jingoo Han <jingoohan1@...il.com>
> Cc: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 4d105ef..4a360bc 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/delay.h>
>  #include <linux/of.h>
> +#include <linux/of_platform.h>
>  #include <linux/types.h>
>  
>  #include "../../pci.h"
> @@ -526,11 +527,16 @@ void dw_pcie_setup(struct dw_pcie *pci)
>  	u32 val;
>  	struct device *dev = pci->dev;
>  	struct device_node *np = dev->of_node;
> +	struct platform_device *pdev;
>  
>  	if (pci->version >= 0x480A || (!pci->version &&
>  				       dw_pcie_iatu_unroll_enabled(pci))) {
>  		pci->iatu_unroll_enabled = true;
> -		if (!pci->atu_base)
> +		pdev = of_find_device_by_node(np);

Use to_platform_device(dev) instead. Put that at the beginning as I'm 
going to move 'dbi' in here too.

> +		if (!pci->atu_base && pdev)
> +			pci->atu_base =
> +			    devm_platform_ioremap_resource_byname(pdev, "atu");
> +		if (IS_ERR_OR_NULL(pci->atu_base))
>  			pci->atu_base = pci->dbi_base + DEFAULT_DBI_ATU_OFFSET;
>  	}
>  	dev_dbg(pci->dev, "iATU unroll: %s\n", pci->iatu_unroll_enabled ?
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives