linux-kernel - Re: [PATCH] nvme: fix use-after-free during booting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA5qM4AuYn4XEHWv5TcHpr77-4yd5os3ykC0FY-JGE-i1McR8Q@mail.gmail.com>
Date:   Wed, 23 Sep 2020 12:40:55 -0400
From:   Tong Zhang <ztong0001@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: fix use-after-free during booting

IMHO, WARN_ON_ONCE() looks ok to me. as long as it won't crash the
system or lead to any memory corruption issue.
We can talk about the reproducer offline if you are interested.
- Tong

On Wed, Sep 23, 2020 at 1:06 AM Christoph Hellwig <hch@....de> wrote:
>
> On Tue, Sep 22, 2020 at 04:34:45PM -0400, Tong Zhang wrote:
> > Hi Christoph,
> > I modified the patch a bit and now it works.
>
> So you're still hitting the WARN_ON_ONCE?  I think we need to fix that
> as well, but all the ideas I have will turn into a bigger project,
> so I think I'll submit this one to Jens, and then do things
> incrementally.
>
> Can you share your reproducer?