[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200923172237.GA32044@linux.intel.com>
Date: Wed, 23 Sep 2020 10:22:37 -0700
From: Sean Christopherson <sean.j.christopherson@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: Vitaly Kuznetsov <vkuznets@...hat.com>,
Wanpeng Li <wanpengli@...cent.com>,
Jim Mattson <jmattson@...gle.com>,
Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] KVM: VMX: Add a helper and macros to reduce
boilerplate for sec exec ctls
On Wed, Sep 23, 2020 at 07:20:17PM +0200, Paolo Bonzini wrote:
> On 23/09/20 18:50, Sean Christopherson wrote:
> > Add a helper function and several wrapping macros to consolidate the
> > copy-paste code in vmx_compute_secondary_exec_control() for adjusting
> > controls that are dependent on guest CPUID bits.
> >
> > No functional change intended.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
> > ---
> > arch/x86/kvm/vmx/vmx.c | 128 +++++++++++++----------------------------
> > 1 file changed, 41 insertions(+), 87 deletions(-)
>
> The diffstat is enticing but the code a little less so... Can you just
> add documentation above vmx_adjust_secondary_exec_control that explains
> the how/why?
Ya, I'd be more than happy to add a big comment.
Powered by blists - more mailing lists