linux-kernel - Re: [PATCH 07/13] block: lift setting the readahead size into the block layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924150318.GE13849@redhat.com>
Date:   Thu, 24 Sep 2020 11:03:19 -0400
From:   Mike Snitzer <snitzer@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-raid@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        Justin Sanders <justin@...aid.com>,
        Minchan Kim <minchan@...nel.org>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        cgroups@...r.kernel.org, linux-bcache@...r.kernel.org,
        Coly Li <colyli@...e.de>, linux-block@...r.kernel.org,
        Song Liu <song@...nel.org>, dm-devel@...hat.com,
        linux-mtd@...ts.infradead.org, Richard Weinberger <richard@....at>,
        drbd-dev@...n.linbit.com, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/13] block: lift setting the readahead size into the
 block layer

On Thu, Sep 24 2020 at  2:51am -0400,
Christoph Hellwig <hch@....de> wrote:

> Drivers shouldn't really mess with the readahead size, as that is a VM
> concept.  Instead set it based on the optimal I/O size by lifting the
> algorithm from the md driver when registering the disk.  Also set
> bdi->io_pages there as well by applying the same scheme based on
> max_sectors.  To ensure the limits work well for stacking drivers a
> new helper is added to update the readahead limits from the block
> limits, which is also called from disk_stack_limits.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Acked-by: Coly Li <colyli@...e.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>

Thanks for adding blk_queue_update_readahead()

Reviewed-by: Mike Snitzer <snitzer@...hat.com>