linux-kernel - Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Sep 2020 20:50:34 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
CC:     <bgolaszewski@...libre.com>, <arnd@...db.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <paul@...zz.com>,
        <jeho@...utexas.edu>
Subject: Re: [PATCH] ARM: davinci: fix kconfig dependency warning when
 !PINCTRL

Hi Necip,

On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote:
> When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
> in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
>   Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
> 
> The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
> or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>

I think its better to fix this by changing the "select PINCTRL_SINGLE"
to "imply PINCTRL_SINGLE". It should be valid to build a DaVinci kernel
without pinctrl support if bootloader is taking care of the pin muxing.

I would not recommend it, but its not illegal either.

While at it, I would drop the other "select PINCTRL" line under "config
MACH_DA8XX_DT". It should not be needed since ARCH_DAVINCI will imply
PINCTRL_SINGLE

Thanks,
Sekhar