linux-kernel - Re: [PATCH] staging: Initial driver submission for pureLiFi devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924153716.GB1171035@kroah.com>
Date:   Thu, 24 Sep 2020 17:37:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Srinivasan Raju <srini.raju@...elifi.com>
Cc:     mostafa.afgani@...elifi.com, pureLiFi Ltd <info@...elifi.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: Initial driver submission for pureLiFi devices

On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote:
> +++ b/drivers/staging/purelifi/chip.c
> @@ -0,0 +1,184 @@
> +// SPDX-License-Identifier: GNU General Public License v2.0 or later

That's not a valid SPDX identifier :)



> +/* Copyright (c) 2015-2020 pureLiFi Ltd
> + * All rights reserved.
> + *
> + * Copyright (C) 2015-2020 pureLiFi <info@...elifi.com>
> + * Copyright (C) 2006-2007 Daniel Drake <dsd@...too.org>
> + * Copyright (C) 2005-2007 Ulrich Kunitz <kune@...ne-taler.de>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

These paragraphs are not needed with a SPDX line above.

thanks,

greg k-h