linux-kernel - Re: [PATCH 1/2] rtw88: Fix probe error handling race with firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200924155021.5DDE8C4339C@smtp.codeaurora.org>
Date:   Thu, 24 Sep 2020 15:50:21 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Yan-Hsuan Chuang <yhchuang@...ltek.com>,
        linux-wireless@...r.kernel.org, Chin-Yen Lee <timlee@...ltek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-realtek-soc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Andreas Färber <afaerber@...e.de>,
        Stanislaw Gruszka <sgruszka@...hat.com>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH 1/2] rtw88: Fix probe error handling race with firmware
 loading

Andreas Färber <afaerber@...e.de> wrote:

> In case of rtw8822be, a probe failure after successful rtw_core_init()
> has been observed to occasionally lead to an oops from rtw_load_firmware_cb():
> 
> [    3.924268] pci 0001:01:00.0: [10ec:b822] type 00 class 0xff0000
> [    3.930531] pci 0001:01:00.0: reg 0x10: [io  0x0000-0x00ff]
> [    3.936360] pci 0001:01:00.0: reg 0x18: [mem 0x00000000-0x0000ffff 64bit]
> [    3.944042] pci 0001:01:00.0: supports D1 D2
> [    3.948438] pci 0001:01:00.0: PME# supported from D0 D1 D2 D3hot D3cold
> [    3.957312] pci 0001:01:00.0: BAR 2: no space for [mem size 0x00010000 64bit]
> [    3.964645] pci 0001:01:00.0: BAR 2: failed to assign [mem size 0x00010000 64bit]
> [    3.972332] pci 0001:01:00.0: BAR 0: assigned [io  0x10000-0x100ff]
> [    3.986240] rtw_8822be 0001:01:00.0: enabling device (0000 -> 0001)
> [    3.992735] rtw_8822be 0001:01:00.0: failed to map pci memory
> [    3.998638] rtw_8822be 0001:01:00.0: failed to request pci io region
> [    4.005166] rtw_8822be 0001:01:00.0: failed to setup pci resources
> [    4.011580] rtw_8822be: probe of 0001:01:00.0 failed with error -12
> [    4.018827] cfg80211: Loading compiled-in X.509 certificates for regulatory database
> [    4.029121] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> [    4.050828] Unable to handle kernel paging request at virtual address edafeaac9607952c
> [    4.058975] Mem abort info:
> [    4.058980]   ESR = 0x96000004
> [    4.058990]   EC = 0x25: DABT (current EL), IL = 32 bits
> [    4.070353]   SET = 0, FnV = 0
> [    4.073487]   EA = 0, S1PTW = 0
> [    4.073501] dw-apb-uart 98007800.serial: forbid DMA for kernel console
> [    4.076723] Data abort info:
> [    4.086415]   ISV = 0, ISS = 0x00000004
> [    4.087731] Freeing unused kernel memory: 1792K
> [    4.090391]   CM = 0, WnR = 0
> [    4.098091] [edafeaac9607952c] address between user and kernel address ranges
> [    4.105418] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [    4.111129] Modules linked in:
> [    4.114275] CPU: 1 PID: 31 Comm: kworker/1:1 Not tainted 5.9.0-rc5-next-20200915+ #700
> [    4.122386] Hardware name: Realtek Saola EVB (DT)
> [    4.127223] Workqueue: events request_firmware_work_func
> [    4.132676] pstate: 60000005 (nZCv daif -PAN -UAO BTYPE=--)
> [    4.138393] pc : rtw_load_firmware_cb+0x54/0xbc
> [    4.143040] lr : request_firmware_work_func+0x44/0xb4
> [    4.148217] sp : ffff800010133d70
> [    4.151616] x29: ffff800010133d70 x28: 0000000000000000
> [    4.157069] x27: 0000000000000000 x26: 0000000000000000
> [    4.162520] x25: 0000000000000000 x24: 0000000000000000
> [    4.167971] x23: ffff00007ac21908 x22: ffff00007ebb2100
> [    4.173424] x21: ffff00007ad35880 x20: edafeaac96079504
> [    4.178877] x19: ffff00007ad35870 x18: 0000000000000000
> [    4.184328] x17: 00000000000044d8 x16: 0000000000004310
> [    4.189780] x15: 0000000000000800 x14: 00000000ef006305
> [    4.195231] x13: ffffffff00000000 x12: ffffffffffffffff
> [    4.200682] x11: 0000000000000020 x10: 0000000000000003
> [    4.206135] x9 : 0000000000000000 x8 : ffff00007e73f680
> [    4.211585] x7 : 0000000000000000 x6 : ffff80001119b588
> [    4.217036] x5 : ffff00007e649c80 x4 : ffff00007e649c80
> [    4.222487] x3 : ffff80001119b588 x2 : ffff8000108d1718
> [    4.227940] x1 : ffff800011bd5000 x0 : ffff00007ac21600
> [    4.233391] Call trace:
> [    4.235906]  rtw_load_firmware_cb+0x54/0xbc
> [    4.240198]  request_firmware_work_func+0x44/0xb4
> [    4.245027]  process_one_work+0x178/0x1e4
> [    4.249142]  worker_thread+0x1d0/0x268
> [    4.252989]  kthread+0xe8/0xf8
> [    4.256127]  ret_from_fork+0x10/0x18
> [    4.259800] Code: f94013f5 a8c37bfd d65f03c0 f9000260 (f9401681)
> [    4.266049] ---[ end trace f822ebae1a8545c2 ]---
> 
> To avoid this, wait on the completion callbacks in rtw_core_deinit()
> before releasing firmware and continuing teardown.
> 
> Note that rtw_wait_firmware_completion() was introduced with
> c8e5695eae9959fc5774c0f490f2450be8bad3de ("rtw88: load wowlan firmware
> if wowlan is supported"), so backports to earlier branches may need to
> inline wait_for_completion(&rtwdev->fw.completion) instead.
> 
> Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
> Fixes: c8e5695eae99 ("rtw88: load wowlan firmware if wowlan is supported")
> Cc: Yan-Hsuan Chuang <yhchuang@...ltek.com>
> Signed-off-by: Andreas Färber <afaerber@...e.de>

2 patches applied to wireless-drivers-next.git, thanks.

ecda9cda3338 rtw88: Fix probe error handling race with firmware loading
ac4bac99161e rtw88: Fix potential probe error handling race with wow firmware loading

-- 
https://patchwork.kernel.org/patch/11787655/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches