[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq1y2kzkw1h.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 24 Sep 2020 11:57:14 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: Jens Axboe <axboe@...nel.dk>, Song Liu <song@...nel.org>,
Hans de Goede <hdegoede@...hat.com>,
Coly Li <colyli@...e.de>, Richard Weinberger <richard@....at>,
Minchan Kim <minchan@...nel.org>,
Johannes Thumshirn <Johannes.Thumshirn@....com>,
Justin Sanders <justin@...aid.com>,
linux-mtd@...ts.infradead.org, dm-devel@...hat.com,
linux-block@...r.kernel.org, linux-bcache@...r.kernel.org,
linux-kernel@...r.kernel.org, drbd-dev@...n.linbit.com,
linux-raid@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-mm@...ck.org, cgroups@...r.kernel.org
Subject: Re: [PATCH 07/13] block: lift setting the readahead size into the
block layer
Christoph,
> Drivers shouldn't really mess with the readahead size, as that is a VM
> concept. Instead set it based on the optimal I/O size by lifting the
> algorithm from the md driver when registering the disk. Also set
> bdi->io_pages there as well by applying the same scheme based on
> max_sectors. To ensure the limits work well for stacking drivers a
> new helper is added to update the readahead limits from the block
> limits, which is also called from disk_stack_limits.
Looks good!
Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists