linux-kernel - Re: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924162332.GH4754@sirena.org.uk>
Date:   Thu, 24 Sep 2020 17:23:32 +0100
From:   Mark Brown <broonie@...nel.org>
To:     cy_huang <u0084500@...il.com>
Cc:     lgirdwood@...il.com, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, cy_huang@...htek.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for
 Richtek RTMV20

On Thu, Sep 24, 2020 at 11:04:51PM +0800, cy_huang wrote:

> +  enable-gpio:
> +    description: A connection of the 'enable' gpio line.
> +    maxItems: 1

-gpios.  GPIO properties should always be plural even if there's only
one GPIO.

> +  ld_pulse_delay:

Properties should use - not _ and for all the properties specifying
things like times you should have units so...

> +    description: |
> +      load current pulse delay in microsecond after strobe pin pulse high.
> +    $ref: "/schemas/types.yaml#/definitions/uint32"

...add -us here.

> +  fsin_enable:
> +    description: Fsin function enable control.
> +    $ref: "/schemas/types.yaml#/definitions/uint32"
> +    minimum: 0
> +    maximum: 1
> +    default: 0

This looks like it should be a boolean property not a number.  The same
is true for most if not all of the other properties with min/max of 0/1.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)