linux-kernel - Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <043f9a77-784d-e887-19e0-57e42ff6bddc@gmail.com>
Date:   Thu, 24 Sep 2020 20:44:20 +0200
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Blaž Hrastnik <blaz@...n.io>,
        Dorian Stoll <dorian.stoll@...p.io>
Subject: Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface

On 9/24/20 9:41 AM, Arnd Bergmann wrote:
> On Thu, Sep 24, 2020 at 12:23 AM Maximilian Luz <luzmaximilian@...il.com> wrote:
>> On 9/23/20 8:51 PM, Arnd Bergmann wrote:
>>> On Wed, Sep 23, 2020 at 8:29 PM Maximilian Luz <luzmaximilian@...il.com> wrote:
>>>> On 9/23/20 6:48 PM, Arnd Bergmann wrote:
>>>
>>> The version I showed avoids the pointers and is compatible with
>>> 32-bit user space.
>>
>> I'm not completely convinced yet that the read/write approach is the way
>> I want to do it, especially with Greg suggesting a misc device, but I'll
>> keep your solution in mind.
> 
> In case of a character device, I'd go with an ioctl to keep it extensible.
> 
> The read/write based interface is what I'd use in debugfs.

Perfect, thanks!

I'll follow Greg's suggestion and create a misc device, and then go for
the IOCTL interface as you suggest.

Thanks again,
Max