linux-kernel - Re: [PATCH net-next] net: hns3: Constify static structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200923.173235.1213061924568928589.davem@davemloft.net>
Date:   Wed, 23 Sep 2020 17:32:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rikard.falkeborn@...il.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com, kuba@...nel.org,
        tanhuazhong@...wei.com, moyufeng@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: hns3: Constify static structs

From: Rikard Falkeborn <rikard.falkeborn@...il.com>
Date: Tue, 22 Sep 2020 00:55:17 +0200

> A number of static variables were not modified. Make them const to allow
> the compiler to put them in read-only memory. In order to do so,
> constify a couple of input pointers as well as some local pointers.
> This moves about 35Kb to read-only memory as seen by the output of the
> size command.
> 
> Before:
>    text    data     bss     dec     hex filename
>  404938  111534     640  517112   7e3f8 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge.ko
> 
> After:
>    text    data     bss     dec     hex filename
>  439499   76974     640  517113   7e3f9 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge.ko
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Applied.