linux-kernel - Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924193807.GA1223313@ravnborg.org>
Date:   Thu, 24 Sep 2020 21:38:07 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Guido Günther <agx@...xcpu.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on
 mantix panel

Hi Guido.

On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote:
> We need to reset both for the panel to show an image.
> 
> Signed-off-by: Guido Günther <agx@...xcpu.org>
> ---
>  .../bindings/display/panel/mantix,mlaf057we51-x.yaml       | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> index 937323cc9aaa..ba5a18fac9f9 100644
> --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> @@ -35,7 +35,9 @@ properties:
>    vddi-supply:
>      description: 1.8V I/O voltage supply
>  
> -  reset-gpios: true
> +  reset-gpios:
> +    minItems: 2
> +    maxItems: 2

reset-gpios is, as you already wrote, defined in panel-common.yaml.
Do not try to change it here.
It would be much better, I think, to introduce a mantix,reset-gpios
property.

This would avoid that we had two different reset-gpios definitions.

	Sam

>  
>    backlight: true
>  
> @@ -62,7 +64,8 @@ examples:
>              avdd-supply = <&reg_avdd>;
>              avee-supply = <&reg_avee>;
>              vddi-supply = <&reg_1v8_p>;
> -            reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
> +            reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>,
> +                          <&gpio1 24 GPIO_ACTIVE_LOW>;
>              backlight = <&backlight>;
>          };
>      };
> -- 
> 2.26.2