linux-kernel - Re: [PATCH] fbdev: mx3fb: remove unused variable 'irq'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200924201246.GH1223313@ravnborg.org>
Date:   Thu, 24 Sep 2020 22:12:46 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Xiaofei Tan <tanxiaofei@...wei.com>
Cc:     b.zolnierkie@...sung.com, arnd@...db.de,
        laurent.pinchart@...asonboard.com, jani.nikula@...el.com,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH] fbdev: mx3fb: remove unused variable 'irq'

On Thu, Sep 17, 2020 at 05:19:20PM +0800, Xiaofei Tan wrote:
> Remove the variable 'irq' that is set but never used.
> 
> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>

Thanks, applied to drm-misc-next.

	Sam

> ---
>  drivers/video/fbdev/mx3fb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index 603731a..894617d 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -1428,7 +1428,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
>  	struct device *dev = mx3fb->dev;
>  	struct mx3fb_platform_data *mx3fb_pdata = dev_get_platdata(dev);
>  	const char *name = mx3fb_pdata->name;
> -	unsigned int irq;
>  	struct fb_info *fbi;
>  	struct mx3fb_info *mx3fbi;
>  	const struct fb_videomode *mode;
> @@ -1441,7 +1440,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
>  	}
>  
>  	ichan->client = mx3fb;
> -	irq = ichan->eof_irq;
>  
>  	if (ichan->dma_chan.chan_id != IDMAC_SDC_0)
>  		return -EINVAL;
> -- 
> 2.8.1