linux-kernel - Re: [PATCH 0/3] fbdev: stop using compat_alloc_user_space

Open Source and information security mailing list archives

Message-ID: <20200924205436.GP1223313@ravnborg.org>
Date:   Thu, 24 Sep 2020 22:54:36 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Arnd Bergmann <arnd@...db.de>, linux-fbdev@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        "David S . Miller" <davem@...emloft.net>, hch@....de,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] fbdev: stop using compat_alloc_user_space

Hi Daniel/Arnd.

On Fri, Sep 18, 2020 at 02:48:08PM +0200, Daniel Vetter wrote:
> On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote:
> > The fbdev code uses compat_alloc_user_space in a few of its
> > compat_ioctl handlers, which tends to be a bit more complicated
> > and error-prone than calling the underlying handlers directly,
> > so I would like to remove it completely.
> > 
> > This modifies two such functions in fbdev, and removes another
> > one that is completely unused.
> > 
> >     Arnd
> > 
> > Arnd Bergmann (3):
> >   fbdev: simplify fb_getput_cmap()
> >   fbdev: sbuslib: remove unused FBIOSCURSOR32 helper
> >   fbdev: sbuslib: remove compat_alloc_user_space usage
> 
> Looks all good, but we're also kinda looking for a new volunteer for
> handling fbdev patches ... drm-misc commit rights, still not interested?

Hi Daniel - I read the above as an a-b. And Arnd did not take the bait
it seems.

Hi Arnd. checkpatch complained about some whitespace, which I fixed
while applying.
Will push to drm-misc-next tomorrow unless I hear anything else.

	Sam

> -Daniel
> 
> > 
> >  drivers/video/fbdev/core/fbmem.c |  44 +++++------
> >  drivers/video/fbdev/sbuslib.c    | 124 ++++++++++++++++++-------------
> >  2 files changed, 90 insertions(+), 78 deletions(-)
> > 
> > -- 
> > 2.27.0
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives