linux-kernel - Re: [PATCH v2 31/37] kasan, x86, s390: update undef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAeHK+yce9oUVG6J6oofjGLqU5gLLx8b22cqF6AgVWXT778g2g@mail.gmail.com>
Date:   Thu, 24 Sep 2020 23:35:59 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Marco Elver <elver@...gle.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Elena Petrova <lenaptr@...gle.com>,
        Branislav Rankov <Branislav.Rankov@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Will Deacon <will.deacon@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 31/37] kasan, x86, s390: update undef CONFIG_KASAN

On Fri, Sep 18, 2020 at 5:07 PM Andrey Konovalov <andreyknvl@...gle.com> wrote:
>
> On Fri, Sep 18, 2020 at 12:52 PM Marco Elver <elver@...gle.com> wrote:
> >
> > On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
> > [...]
> > >  arch/s390/boot/string.c         | 1 +
> > >  arch/x86/boot/compressed/misc.h | 1 +
> > >  2 files changed, 2 insertions(+)
> > >
> > > diff --git a/arch/s390/boot/string.c b/arch/s390/boot/string.c
> > > index b11e8108773a..faccb33b462c 100644
> > > --- a/arch/s390/boot/string.c
> > > +++ b/arch/s390/boot/string.c
> > > @@ -3,6 +3,7 @@
> > >  #include <linux/kernel.h>
> > >  #include <linux/errno.h>
> > >  #undef CONFIG_KASAN
> > > +#undef CONFIG_KASAN_GENERIC
> >
> > Is CONFIG_KASAN still used to guard instrumented versions of functions?
> >
> > It looks like #undef CONFIG_KASAN is no longer needed -- at least
> > <linux/string.h> no longer mentions it.
>
> I'm pretty sure this is still necessary (something didn't work when I
> forgot to make this change), but I'll check again.

Yes, it still fails, as compressed code provides its own memmove.