linux-kernel - Re: [PATCH -next] crypto: qat - convert to use DEFINE_SEQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924050042.GA32206@silpixa00400314>
Date:   Thu, 24 Sep 2020 06:00:42 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Liu Shixin <liushixin2@...wei.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        qat-linux <qat-linux@...el.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: qat - convert to use DEFINE_SEQ_ATTRIBUTE
 macro

On Wed, Sep 16, 2020 at 03:50:17AM +0100, Liu Shixin wrote:
> Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

> ---
>  drivers/crypto/qat/qat_common/adf_cfg.c       | 19 +--------
>  .../qat/qat_common/adf_transport_debug.c      | 42 ++-----------------
>  2 files changed, 5 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c b/drivers/crypto/qat/qat_common/adf_cfg.c
> index ac462796cefc..22ae32838113 100644
> --- a/drivers/crypto/qat/qat_common/adf_cfg.c
> +++ b/drivers/crypto/qat/qat_common/adf_cfg.c
> @@ -52,24 +52,7 @@ static const struct seq_operations qat_dev_cfg_sops = {
>  	.show = qat_dev_cfg_show
>  };
>  
> -static int qat_dev_cfg_open(struct inode *inode, struct file *file)
> -{
> -	int ret = seq_open(file, &qat_dev_cfg_sops);
> -
> -	if (!ret) {
> -		struct seq_file *seq_f = file->private_data;
> -
> -		seq_f->private = inode->i_private;
> -	}
> -	return ret;
> -}
> -
> -static const struct file_operations qat_dev_cfg_fops = {
> -	.open = qat_dev_cfg_open,
> -	.read = seq_read,
> -	.llseek = seq_lseek,
> -	.release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(qat_dev_cfg);
>  
>  /**
>   * adf_cfg_dev_add() - Create an acceleration device configuration table.
> diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c
> index 2a2eccbf56ec..dac25ba47260 100644
> --- a/drivers/crypto/qat/qat_common/adf_transport_debug.c
> +++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c
> @@ -77,31 +77,14 @@ static void adf_ring_stop(struct seq_file *sfile, void *v)
>  	mutex_unlock(&ring_read_lock);
>  }
>  
> -static const struct seq_operations adf_ring_sops = {
> +static const struct seq_operations adf_ring_debug_sops = {
>  	.start = adf_ring_start,
>  	.next = adf_ring_next,
>  	.stop = adf_ring_stop,
>  	.show = adf_ring_show
>  };
>  
> -static int adf_ring_open(struct inode *inode, struct file *file)
> -{
> -	int ret = seq_open(file, &adf_ring_sops);
> -
> -	if (!ret) {
> -		struct seq_file *seq_f = file->private_data;
> -
> -		seq_f->private = inode->i_private;
> -	}
> -	return ret;
> -}
> -
> -static const struct file_operations adf_ring_debug_fops = {
> -	.open = adf_ring_open,
> -	.read = seq_read,
> -	.llseek = seq_lseek,
> -	.release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(adf_ring_debug);
>  
>  int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)
>  {
> @@ -188,31 +171,14 @@ static void adf_bank_stop(struct seq_file *sfile, void *v)
>  	mutex_unlock(&bank_read_lock);
>  }
>  
> -static const struct seq_operations adf_bank_sops = {
> +static const struct seq_operations adf_bank_debug_sops = {
>  	.start = adf_bank_start,
>  	.next = adf_bank_next,
>  	.stop = adf_bank_stop,
>  	.show = adf_bank_show
>  };
>  
> -static int adf_bank_open(struct inode *inode, struct file *file)
> -{
> -	int ret = seq_open(file, &adf_bank_sops);
> -
> -	if (!ret) {
> -		struct seq_file *seq_f = file->private_data;
> -
> -		seq_f->private = inode->i_private;
> -	}
> -	return ret;
> -}
> -
> -static const struct file_operations adf_bank_debug_fops = {
> -	.open = adf_bank_open,
> -	.read = seq_read,
> -	.llseek = seq_lseek,
> -	.release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(adf_bank_debug);
>  
>  int adf_bank_debugfs_add(struct adf_etr_bank_data *bank)
>  {
> -- 
> 2.25.1
>