linux-kernel - Re: [PATCH v2] omap3: enable off mode automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924090047.2b61f883@aktux>
Date:   Thu, 24 Sep 2020 09:00:47 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     khilman@...nel.org, tony@...mide.com, linux@...linux.org.uk,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH v2] omap3: enable off mode automatically

On Fri, 11 Sep 2020 18:12:09 +0200
Andreas Kemnade <andreas@...nade.info> wrote:

> Enabling off mode was only reachable deeply hidden
> in the debugfs. As powersaving is an important feature,
> move the option out of its shady place.
> The debugfs file can still be used to override the default.
> 
> Use the presence of a device compatible to ti,twl4030-idle or
> ti,twl4030-idle-osc-off as an indicator that the board is wired correctly
> for off mode.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
> An earlier version of this patch was here:
> https://patchwork.kernel.org/patch/10794121/
> 
> A config option was used instead of the suggested devicetree check.
> 
> Changes in v2:
> - fix compile without CONFIG_ARCH_OMAP3
>   The variable enable_off_mode is now always a real one and not
>   a preprocessor constant to avoid trouble with unusual configurations.
> 
Anything I still missed here? 

Regards,
Andreas