linux-kernel - Re: [PATCH -next] tee: optee: fix type warning of sizeof in pool_op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Sep 2020 09:33:21 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Liu Shixin <liushixin2@...wei.com>
Cc:     op-tee@...ts.trustedfirmware.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] tee: optee: fix type warning of sizeof in pool_op_alloc()

On Thu, Sep 17, 2020 at 9:52 AM Liu Shixin <liushixin2@...wei.com> wrote:
>
> sizeof() when applied to a pointer typed expression should gives the
> size of the pointed data, even if the data is a pointer.
>
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> ---
>  drivers/tee/optee/shm_pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/shm_pool.c b/drivers/tee/optee/shm_pool.c
> index d767eebf30bd..9fdc667b5df0 100644
> --- a/drivers/tee/optee/shm_pool.c
> +++ b/drivers/tee/optee/shm_pool.c
> @@ -31,7 +31,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm,
>                 unsigned int nr_pages = 1 << order, i;
>                 struct page **pages;
>
> -               pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
> +               pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);

In this case we want an array of pointers as you also can see in the
type of "pages".

Thanks,
Jens

>                 if (!pages)
>                         return -ENOMEM;
>
> --
> 2.25.1
>