linux-kernel - Re: [PATCH v3 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Sep 2020 12:51:35 +0300
From:   Roger Quadros <rogerq@...com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>, <balbi@...nel.org>
CC:     <pawell@...ence.com>, <kurahul@...ence.com>, <nsekhar@...com>,
        <vigneshr@...com>, <robh+dt@...nel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] dt-bindings: usb: cdns,usb3: Add
 cdns,phyrst-a-enable property

Hi Sergei,

On 15/09/2020 19:15, Sergei Shtylyov wrote:
> Hello!
> 
> On 9/15/20 2:45 PM, Roger Quadros wrote:
> 
>> Controller version 0x0002450D has USB2 PHY RX sensitivity issues
>> that needs to be worked around by enabling phyrst-a-enable bit
>> in PHYRST_CFG register.
>>
>> There is no way to know controller version before device controller
>> is started and the workaround needs to be applied for both host and
>> device modes, so we add this DT property.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> Acked-by: Rob Herring <robh@...nel.org>
>> ---
>>   Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> index 9b14c8443d39..ac20b98e9910 100644
>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> @@ -61,6 +61,10 @@ properties:
>>         buffers expressed in KB
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>   
>> +  cdns,phyrst-a-enable:
>> +    description: Enable resetting of PHY if Rx fail is detected
> 
>     Failure?

Actually the IP manual says "Reset PHY if Rx fail is detected".

So let's leave it like that.
> 
> [...]
> 
> MBR, Sergei
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki