[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200924102534.GI2483160@ulmo>
Date: Thu, 24 Sep 2020 12:25:34 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Nicolin Chen <nicoleotsuka@...il.com>
Cc: joro@...tes.org, linux-kernel@...r.kernel.org,
iommu@...ts.linux-foundation.org, linux-tegra@...r.kernel.org,
jonathanh@...dia.com, vdumpa@...dia.com
Subject: Re: [PATCH 3/3] iommu/tegra-smmu: Allow to group clients in same
swgroup
On Fri, Sep 11, 2020 at 12:16:43AM -0700, Nicolin Chen wrote:
> There can be clients using the same swgroup in DT, for example i2c0
> and i2c1. The current driver will add them to separate IOMMU groups,
> though it has implemented device_group() callback which is to group
> devices using different swgroups like DC and DCB.
>
> All clients having the same swgroup should be also added to the same
> IOMMU group so as to share an asid. Otherwise, the asid register may
> get overwritten every time a new device is attached.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
> drivers/iommu/tegra-smmu.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Makes sense:
Acked-by: Thierry Reding <treding@...dia.com>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists