linux-kernel - Re: [PATCH] KVM: x86/mmu: Stash 'kvm' in a local variable in kvm_mmu_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924143922.GA22539@linux.intel.com>
Date:   Thu, 24 Sep 2020 07:39:24 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Stash 'kvm' in a local variable in
 kvm_mmu_free_roots()

On Thu, Sep 24, 2020 at 02:42:19PM +0200, Vitaly Kuznetsov wrote:
> What about kvm_mmu_get_page(), make_mmu_pages_available(),
> mmu_alloc_root(), kvm_mmu_sync_roots(), direct_page_fault(),
> kvm_mmu_pte_write() which seem to be using the same ugly pattern? :-)

Heh, good question.  I guess only kvm_mmu_free_roots() managed to cross over
the threshold from "that's ugly" to "this is ridiculous".