linux-kernel - Re: [MPTCP][PATCH net-next 08/16] mptcp: remove addr and subflow in PM netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009241720290.62831@mmahler-mobl1.amr.corp.intel.com>
Date:   Thu, 24 Sep 2020 17:20:43 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Geliang Tang <geliangtang@...il.com>
cc:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        mptcp@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [MPTCP][PATCH net-next 08/16] mptcp: remove addr and subflow in
 PM netlink

On Thu, 24 Sep 2020, Geliang Tang wrote:

> This patch implements the remove announced addr and subflow logic in PM
> netlink.
>
> When the PM netlink removes an address, we traverse all the existing msk
> sockets to find the relevant sockets.
>
> We add a new list named anno_list in mptcp_pm_data, to record all the
> announced addrs. In the traversing, we check if it has been recorded.
> If it has been, we trigger the RM_ADDR signal.
>
> We also check if this address is in conn_list. If it is, we remove the
> subflow which using this local address.
>
> Since we call mptcp_pm_free_anno_list in mptcp_destroy, we need to move
> __mptcp_init_sock before the mptcp_is_enabled check in mptcp_init_sock.
>
> Suggested-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Suggested-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Acked-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
> net/mptcp/pm.c         |   7 ++-
> net/mptcp/pm_netlink.c | 122 +++++++++++++++++++++++++++++++++++++++--
> net/mptcp/protocol.c   |   9 +--
> net/mptcp/protocol.h   |   2 +
> net/mptcp/subflow.c    |   1 +
> 5 files changed, 130 insertions(+), 11 deletions(-)

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel