linux-kernel - Re: [PATCH -next] media: venus: simplify the return expression of session_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200925151328.GC2510@yoga>
Date:   Fri, 25 Sep 2020 10:13:28 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] media: venus: simplify the return expression of
 session_process_buf()

On Mon 21 Sep 08:10 CDT 2020, Qinglang Miao wrote:

> Simplify the return expression.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/media/platform/qcom/venus/helpers.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 50439eb1f..fb3fd3640 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -439,7 +439,6 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
>  	struct vb2_buffer *vb = &vbuf->vb2_buf;
>  	unsigned int type = vb->type;
>  	struct hfi_frame_data fdata;
> -	int ret;
>  
>  	memset(&fdata, 0, sizeof(fdata));
>  	fdata.alloc_len = buf->size;
> @@ -470,11 +469,7 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
>  		fdata.offset = 0;
>  	}
>  
> -	ret = hfi_session_process_buf(inst, &fdata);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return hfi_session_process_buf(inst, &fdata);
>  }
>  
>  static bool is_dynamic_bufmode(struct venus_inst *inst)
> -- 
> 2.23.0
>