linux-kernel - Re: [PATCH 1/2] ASoC: qdsp6: Drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04e564b5-2345-2e44-72f3-9a388e76b4ab@linaro.org>
Date:   Fri, 25 Sep 2020 17:24:27 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] ASoC: qdsp6: Drop of_match_ptr to fix
 -Wunused-const-variable



On 25/09/2020 17:17, Mark Brown wrote:
> On Fri, Sep 25, 2020 at 09:49:24AM +0100, Srinivas Kandagatla wrote:
>> The of_device_id is included unconditionally by of.h header and used
>> in the driver as well.  Remove of_match_ptr to fix W=1 compile test
>> warning with !CONFIG_OF:
> 
> It's better to fix this by adding #ifdefs around the table so that we
> don't have unneeded bloat from the match table in !OF cases.
> 
sure, I will respin series with that change!

--srini