linux-kernel - Re: [PATCH] cpuidle-haltpoll: fix error comments in arch_haltpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f505ee30-6d13-5b48-e772-c715b78c2400@redhat.com>
Date:   Fri, 25 Sep 2020 22:15:58 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Li Qiang <liq3ea@....com>, x86@...nel.org, kvm@...r.kernel.org,
        mtosatti@...hat.com
Cc:     liq3ea@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpuidle-haltpoll: fix error comments in
 arch_haltpoll_disable

On 24/09/20 17:58, Li Qiang wrote:
> The 'arch_haltpoll_disable' is used to disable guest halt poll.
> Correct the comments.
> 
> Fixes: a1c4423b02b21 ("cpuidle-haltpoll: disable host side polling when kvm virtualized")
> Signed-off-by: Li Qiang <liq3ea@....com>
> ---
>  arch/x86/kernel/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 08320b0b2b27..94ebb31cb4ce 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -954,7 +954,7 @@ void arch_haltpoll_disable(unsigned int cpu)
>  	if (!kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL))
>  		return;
>  
> -	/* Enable guest halt poll disables host halt poll */
> +	/* Disable guest halt poll enables host halt poll */
>  	smp_call_function_single(cpu, kvm_enable_host_haltpoll, NULL, 1);
>  }
>  EXPORT_SYMBOL_GPL(arch_haltpoll_disable);
> 

Queued, thanks.

Paolo