linux-kernel - Re: [PATCH v3 0/5] KVM: VMX: Clean up RTIT MAXPHYADDR usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f694762-6b8c-be1b-c0f0-5f7897866b66@redhat.com>
Date:   Fri, 25 Sep 2020 21:50:02 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] KVM: VMX: Clean up RTIT MAXPHYADDR usage

On 24/09/20 21:42, Sean Christopherson wrote:
> Stop using cpuid_query_maxphyaddr() for a random RTIT MSR check, unexport
> said function to discourage future use, and do additional related cleanup.
> 
> Paolo, feel free to reorder/squash these as you see fit.  Five patches
> feels more than a bit gratuitous, but every time I tried to squash things
> I ended up with changelogs that ran on and on...
> 
> v2:
>   - Rebased to kvm/queue, commit e1ba1a15af73 ("KVM: SVM: Enable INVPCID
>     feature on AMD").
> 
> Sean Christopherson (5):
>   KVM: VMX: Use precomputed MAXPHYADDR for RTIT base MSR check
>   KVM: x86: Unexport cpuid_query_maxphyaddr()
>   KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function
>   KVM: x86: Move illegal GPA helper out of the MMU code
>   KVM: VMX: Use "illegal GPA" helper for PT/RTIT output base check
> 
>  arch/x86/kvm/cpuid.c   |  1 -
>  arch/x86/kvm/cpuid.h   |  5 +++++
>  arch/x86/kvm/mmu.h     |  5 -----
>  arch/x86/kvm/mmu/mmu.c |  2 +-
>  arch/x86/kvm/vmx/vmx.c | 13 ++++++++-----
>  5 files changed, 14 insertions(+), 12 deletions(-)
> 

Queued, thanks.

Paolo