[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fXp8brNy7tCTAp4H1uegnCkrBxCiacz14+K3TY4_t3hVA@mail.gmail.com>
Date: Fri, 25 Sep 2020 12:43:45 -0700
From: Ian Rogers <irogers@...gle.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
"Jin, Yao" <yao.jin@...ux.intel.com>,
Konstantin Ryabitsev <konstantin@...uxfoundation.org>,
Jiri Olsa <jolsa@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...nel.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
LKML <Linux-kernel@...r.kernel.org>,
Kan Liang <kan.liang@...el.com>
Subject: Re: [PATCH v2 1/2] perf vendor events: Update CascadelakeX events to v1.08
On Fri, Sep 25, 2020 at 11:36 AM Andi Kleen <andi@...stfloor.org> wrote:
>
> > Thanks, it now works, but then... You forgot to add the Cc: entries for
> > all the people in your actual e-mail Cc: list, and also the
> > Reviewed-by: from Andy, I had to do it all manually, so when I applied
> > your attachments with 'git am' I needed to go on and manually collect
> > all the Cc, Reviewed-by and Acked-by tags.
>
> For the event updates we should just use git pulls in my opinion.
>
> They are just too large for the normal review procedures, and usually
> don't really benefit much from community review anyways because they
> are essentially hardware documentation.
>
> Should just name intel / amd / etc. event list maintainers and you
> could accept pulls from them.
>
> -Andi
Are the scripts to make the json available? Perhaps then Arnaldo could
generate the changes.
I believe Kajol Jain has some unmerged changes because there's a worry
about the interaction with the scripts and assumptions in jevents.
Having access to the scripts would mean that we could fix whatever
issues there would be.
Thanks,
Ian
Powered by blists - more mailing lists