linux-kernel - Re: [PATCH v8 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq18scxinmw.fsf@ca-mkp.ca.oracle.com>
Date:   Fri, 25 Sep 2020 16:54:07 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Coly Li <colyli@...e.de>
Cc:     linux-block@...r.kernel.org, linux-nvme@...ts.infradead.org,
        netdev@...r.kernel.org, open-iscsi@...glegroups.com,
        linux-scsi@...r.kernel.org, ceph-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vasily Averin <vvs@...tuozzo.com>,
        Cong Wang <amwang@...hat.com>,
        Mike Christie <michaelc@...wisc.edu>,
        Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>,
        Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v8 6/7] scsi: libiscsi: use sendpage_ok() in
 iscsi_tcp_segment_map()


Coly,

> In iscsci driver, iscsi_tcp_segment_map() uses the following code to
> check whether the page should or not be handled by sendpage:
>     if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
>
> The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to
> make sure the page can be sent to network layer's zero copy path. This
> part is exactly what sendpage_ok() does.
>
> This patch uses  use sendpage_ok() in iscsi_tcp_segment_map() to replace
> the original open coded checks.

Looks fine to me.

Acked-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering