linux-kernel - Re: [PATCH v2 2/3] Input: atmel_mxt_ts - implement I2C retries for mXT1368

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <285f5b25-820c-4402-0ebf-5bac87c95d84@gmail.com>
Date:   Sat, 26 Sep 2020 00:01:25 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jiada Wang <jiada_wang@...tor.com>, dmitry.torokhov@...il.com,
        robh+dt@...nel.org, thierry.reding@...il.com, jonathanh@...dia.com
Cc:     nick@...anahar.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        erosca@...adit-jv.com, andrew_gabbasov@...tor.com
Subject: Re: [PATCH v2 2/3] Input: atmel_mxt_ts - implement I2C retries for
 mXT1368

25.09.2020 16:52, Jiada Wang пишет:
> According to datasheet, mXT1386 chip has a WAKE line, it is used
> to wake the chip up from deep sleep mode before communicating with
> it via the I2C-compatible interface.
> 
> if the WAKE line is connected to a GPIO line, the line must be
> asserted 25 ms before the host attempts to communicate with the mXT1386.
> If the WAKE line is connected to the SCL pin, the mXT1386 will send a
> NACK on the first attempt to address it, the host must then retry 25 ms
> later.
> 
> This patch adds compatible string "atmel,mXT1386" for mXT1386 controller,
> when I2C transfer on mXT1386 fails, retry the transfer once after a 25 ms
> sleep.
> 
> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c | 62 +++++++++++++++++++-----
>  1 file changed, 50 insertions(+), 12 deletions(-)

Hello, Jiada! Thank you very much!

Will be nice if this patch could land to v5.10 :)

Reviewed-by: Dmitry Osipenko <digetx@...il.com>
Tested-by: Dmitry Osipenko <digetx@...il.com>