linux-kernel - Re: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200925.164932.397279241814019073.davem@davemloft.net>
Date:   Fri, 25 Sep 2020 16:49:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vee.khee.wong@...el.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, kuba@...nel.org, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        andriy.shevchenko@...ux.intel.com, boon.leong.ong@...el.com,
        weifeng.voon@...el.com, sadhishkhanna.vijaya.balan@...el.com,
        chen.yong.seow@...el.com, mgross@...ux.intel.com
Subject: Re: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path

From: Wong Vee Khee <vee.khee.wong@...el.com>
Date: Fri, 25 Sep 2020 17:54:06 +0800

> While unloading the dwmac-intel driver, clk_disable_unprepare() is
> being called twice in stmmac_dvr_remove() and
> intel_eth_pci_remove(). This causes kernel panic on the second call.
> 
> Removing the second call of clk_disable_unprepare() in
> intel_eth_pci_remove().
> 
> Fixes: 09f012e64e4b ("stmmac: intel: Fix clock handling on error and remove paths")
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Voon Weifeng <weifeng.voon@...el.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@...el.com>

Applied, thanks.